Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31 / 홈 UI 구현 #41

Merged
merged 9 commits into from
Jul 15, 2023
Merged

#31 / 홈 UI 구현 #41

merged 9 commits into from
Jul 15, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Jul 15, 2023

📌 관련 이슈

📷 screenshot

📝 Work Desciption

  • 홈 UI 구현
  • 한판 승부와 소원권 리플 효과 적용
  • Wish 쪽 ScrollView안에 FragmentContainer 있는 이슈 해결!
  • 홈에서 다른 화면으로 전환 구현

📚 Reference 혹은 궁금한 사항들

  • 각자 화면과 HomeActivity가 매끄럽게 이어질 수 있게 각자 화면에서 뒤로 가기 로직을 다듬어 주세요!
  • 마이페이지는 추후에 UI 나오면 연결하겠습니다
  • 하트 다이얼로그 연결은 따로 pr 올리겠습니다.

@taeheeL taeheeL added feat 구현 및 개선 UI UI 작업 태희 🦊 유니의 대장 담당 labels Jul 15, 2023
@taeheeL taeheeL added this to the Phase2 milestone Jul 15, 2023
@taeheeL taeheeL requested a review from a team July 15, 2023 06:15
@taeheeL taeheeL self-assigned this Jul 15, 2023
Comment on lines -53 to 55
val intent = Intent(this, MainActivity::class.java)
val intent = Intent(this, HomeActivity::class.java)
startActivity(intent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

액티비티 익스텐션에 인텐트하는거 있던데 put하는 값없으면 그거 써봐도 될듯??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이건 제 코드가 아니긴 합니다 ㅎㅎ

Copy link
Member

@l2zh l2zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

형 화이팅!


private fun moveToShortGame() {
binding.clShortGame.setOnSingleClickListener {
startActivity<CreateShortGameActivity>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 있었네 저도 이걸로 써서 고치겠습니당

Copy link
Member

@sub101 sub101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 대장 👍🏻👍🏻

@taeheeL taeheeL merged commit efdf17a into develop Jul 15, 2023
1 check passed
@taeheeL taeheeL deleted the feature/#31-home-ui branch July 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 태희 🦊 유니의 대장 담당 UI UI 작업
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants